Re: Feedback request: Disable logging Client IP’s in the Gorouter logs for compliance with the EU General Data Protection Regulation (GDPR)

Shubha Anjur Tupil
 

Filip,

I agree that adding a configuration is not a very elegant solution. The Gorouter currently does not support a "Access Log Format" and while it is an elegant solution, the complexity of implementing and rolling it out (testing, maintenance, documentation) seems more than what we are willing to invest in right now. 

As we mention our main use case at this point is to enable our customers to be compliant with the EU General Data Protection Regulation (GDPR) (enforcement begins in May). Do you know if there are other component teams within CF that use a log format structure, we couldn't think of any? 

Regards, 
Shubha



On Tue, Mar 13, 2018 at 12:27 PM, Filip Hanik <fhanik@...> wrote:
having a property to disable one single header logging sounds like overkill. what if I want to disable other headers

Is the gorouter not using an "Access Log Format" string that effectively lets you create the format of the log that you need? That may be worth considering.
this would be fairly common practice around any type of http endpoint logging




On Mon, Mar 12, 2018 at 4:39 PM, Shubha Anjur Tupil <sanjurtupil@...> wrote:

Hello everyone, 

In lieu of The EU General Data Protection Regulation (GDPR), the routing team is investigating adding manifest properties to allow an operator to disable logging the client IP's in the X-Forwarded-For header in the access and error logs for Gorouter.

Enforcement of The EU General Data Protection Regulation (GDPR) (https://www.eugdpr.org/) begins May 28th and imposes steep fines. This law says that companies will be fined if they are capturing PII. The Gorouter currently captures Client IP addresses that are included in that definition. We are exploring manifest properties to allow operators to disable logging the originating client IP.

We need help weighing the options given the use-cases.

Use-cases:

#1. L3 Load Balancer e.g. Amazon NLB in front of the Gorouter 
The client IP is logged and the X-Forwarded-For header might have the originating client IP if an intermediary component or the originating client is adding the header.

#2. L7 Load Balancer e.g. Amazon NLB in front of the Gorotuer 
The client IP is the IP of the load balancer in front of the Gorouter, but the X-Forwarded-For header has the originating client IP.

Option1: We have one manifest property to disable logging both the X-Forwarded-For header and the Client IP in the Gorouter logs.

For use-case #1 this works, and there is only one manifest property to disable all PII being logged by the Gorouter.

For use-case #2 this results in the operator losing the LB IP which might be helpful for troubleshooting.

Option2: We have two separate manifest properties to disable logging the X-Forwarded-For header and/or the Client IP in the Gorouter logs. This is generally more flexible at the cost of user experience.

For use-case #1 this would mean that an operator would have to set two manifest properties instead of one. Both these properties would need to be exposed in Ops Man for PCF installations. It leads to a more cumbersome user experience, adding to the already long list of options.

For use-case #2 this results in a better outcome for an operator in that they still get the information on the LB the request came from, while the originating client IP will not be logged.

Based on the information we have, we are not sure which experience is better and which use-case to optimize for. Some questions we have

  1. What type of LB is more popular in CF environments; L3 or L7? This might help us optimize for Use-case #2 and go with Option #2.
  2. Is there a compelling reason from an operator perspective for installations with a L7 load balancer, making it important to have the Client IP (i.e. they would absolutely want to have Option #2 or maybe don’t care and Option #1 would be ok)?
  3. Does the user experience benefit by having just one option outweigh the benefit of having the client IP for an operator with an L7 Load Balancer? (Flexibility over Experience)

We would love to hear from you if you have thoughts on this. 

Thanks, 

Shannon Coen & Shubha Anjur Tupil
Product Managers, CF Routing




Join cf-dev@lists.cloudfoundry.org to automatically receive all group messages.