Metron_agent setup_syslog_forwarder.sh should be split in a different job
Hector Rivas Gandara
Hello,
Currently we are using the feature of metron_agent to configure rsyslog to forward all the logs to a central syslog endpoint[1] This is great, but I wonder if this feature should be really part of the job "metron_agent". Our case is that we want to configure this feature in ALL our VMs, even the ones that are not purely CF components (nozzles, database brokers, etc). But in order to configure it consistently, we need to install metron_agent, which is not being used in that VM. Installing metron_agent when the only goal is collaterally configure rsyslog s completely unnecessary. My proposal is that we split this to a new job, something like "rsyslog_forwarder". What do you think? We can do a PR if that is OK. [1] https://github.com/cloudfoundry/loggregator/blob/a6890ed17c9a4d1bd7ce9203df027858047aa030/jobs/metron_agent/spec#L29-L47 https://github.com/cloudfoundry/loggregator/blob/a6890ed17c 9a4d1bd7ce9203df027858047aa030/src/metron/syslog_daemon_conf ig/setup_syslog_forwarder.sh https://github.com/cloudfoundry/loggregator/blob/a6890ed17c9a4d1bd7ce9203df027858047aa030/jobs/metron_agent/templates/metron_agent_ctl.erb#L22-L24 <https://github.com/cloudfoundry/loggregator/blob/a6890ed17c9a4d1bd7ce9203df027858047aa030/src/metron/syslog_daemon_config/setup_syslog_forwarder.sh> -- Regards Hector Rivas | GDS / Multi-Cloud PaaS |
|