Re: Adding previous_instances and previous_memory fields to cf_event


Hristo Iliev
 

Hi,

Seems this was merged 4 days ago.

Thanks a lot,
Hristo Iliev

On 4 Apr 2016 15:49, "Hristo Iliev" <hsiliev(a)gmail.com> wrote:

Hey,

Any news about this PR? We tried to minimize the change and make it easer
for review.

Regards,
Hristo Iliev

2016-03-29 14:50 GMT+03:00 Hristo Iliev <hsiliev(a)gmail.com>:

Hi again,

We created https://github.com/cloudfoundry/cloud_controller_ng/pull/569

Can you please take a look and comment on possible problems and missed
use-cases?

Regards,
Hristo Iliev

2016-03-24 18:06 GMT+02:00 Hristo Iliev <hsiliev(a)gmail.com>:

Hi Nick,

Adding previous state sounds good. Will add it in the PR as well.

Thanks,
Hristo Iliev

2016-03-24 17:29 GMT+02:00 Nicholas Calugar <ncalugar(a)pivotal.io>:

Hi Hristo,

I'm fine with a PR to add these two fields. Would it make sense to add
previous state as well?

Thanks,

Nick

On Thu, Mar 24, 2016 at 12:59 AM Dieu Cao <dcao(a)pivotal.io> wrote:

Hi Hristo,

I think a PR to add them would be fine, but I would defer to Nick
Calugar, who's taking over as PM of CAPI, to make that call.

-Dieu

On Wed, Mar 23, 2016 at 2:12 PM, Hristo Iliev <hsiliev(a)gmail.com>
wrote:

Hi again,

Would you consider a PR that adds previous memory & instances to the
app usage events? Does this two additional fields make a sense?

Regards,
Hristo Iliev

Join cf-dev@lists.cloudfoundry.org to automatically receive all group messages.