Re: Announcing Experimental support for Asynchronous Service Operations
|
Thanks Dieu for your response.
toggle quoted messageShow quoted text
We have successfully implemented an async service broker for out internal dbaas [1], [2] which db farms provisionning sometimes takes longer than 30s. Concerning improvement suggestions on the documentation, I could only spot an inconsistency on the sequence diagram, where the last operation description is mismatching between broker response (1/3 nodes") and CC api response ("40% complete") whereas the 'description' is a string which should be returned as is. Hard to propose a PR on that since the source file for this diagram does not seem available under docs-services [4]. BTW, It would be great if bookbinder would support rendering diagrams from a text format such as plantuml [5], or rely on plantuml public service [6] for such rendering. Wouldn't is make sense to exit the experimental status of the async api, even if it's not feature complete ? i.e. considering the api is stable enough and won't change in an incompatible maneer soon, thereby enabling clients such as cf-java-client to rely on them. One other potential improvement I see to the API would be to support localized user-facing operation status description. Having the CLI being I18Ned but brokers enable to return user facing messages in the user language seems limiting. Maybe it could be the case of having the CLI add a usual 'Accept-Language: zh_Hans" matching the current CLI locale, and the CC propagating this header in the last_operation broker endpoint [7] so that they can return the status message in the smae language when translations are available. Thanks, Guillaume. [1] https://github.com/Orange-OpenSource/elpaaso-brokers/blob/master/cf-service-broker-dbaas/src/main/java/com/orange/clara/cloud/cf/servicebroker/dbaas/service/DbaasServiceInstanceService.java#L60 [2] https://github.com/Orange-OpenSource/elpaaso-brokers/blob/a3f150fc7d3bb889875aac202496a4f63efc3595/cf-service-broker-dbaas/src/main/java/com/orange/clara/cloud/cf/servicebroker/dbaas/service/DbaasServiceInstanceService.java#L67-L73 [3] http://docs.cloudfoundry.org/services/images/async-service-broker-flow.png [4] https://github.com/cloudfoundry/docs-services/blob/master/images/async-service-broker-flow.png [5] http://plantuml.com/sequence.html [6] http://plantuml.com/plantuml/ [7] http://docs.cloudfoundry.org/services/asynchronous-operations.html#polling
On Tue, Sep 1, 2015 at 5:50 PM, Dieu Cao <dcao(a)pivotal.io> wrote:
Hi Guillaume,
|
|
|